Make template lint use node glob to ensure consistent lint results across OS #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elyseum
changed the title
…Sitecore#1958) * [XM Cloud][Angular] Navigation component link forces full page reload * Updated Image, LinkList, Promo, Title components
* remove duplicate changelog entry * add cdp page view component to send page view events * minor update of imports * update changelog * some fixes - handle empty language, handle send event error; * do not initialize csdk and send events if not in production mode * add comment Co-authored-by: Illia Kovalenko <[email protected]> * fix comment intendation * minor update of changelog entry Co-authored-by: Illia Kovalenko <[email protected]> * rename personalize scop environment variable * add migration guide entry for page view tracking * add migrate guide for cloud sdk init * update changelog * remove 'public' prefix of the personalize scope env variable --------- Co-authored-by: Illia Kovalenko <[email protected]>
…eview mode (Sitecore#1961) * modify cloudsk init component to not initialize cloudsk if in edit or preview mode or missing route data * changelog update * update migration entry for csdk initialization * modify csdk initialization logic to run only once in the browser
* Upgrade cloudsdk to 0.4.0 * Remove context logic * use @sitecore/components 2.0
…Sitecore#1962) * [Chore] New Angular add-on's are not scaffolded within PR Build pipeline * Updated CHANGELOG * Updated utils
…sonalizeMiddlewareConfig (Sitecore#1963) * pass setPersonalizeCookie by default in personalize-middleware
Co-authored-by: illiakovalenko <[email protected]>
…de to v0.5.19. Updated @sitecore-cloudsdk to v0.4.1. (Sitecore#1966) * [BYOC] Updated @sitecore-feaas/clientside to v0.5.19, passed rendering data to FEAAS.ExternalComponent * Updated CloudSDK to 0.4.1 * Updated CHANGELOG * Updated CHANGELOG * Updated yarn.lock * Updated @sitecore/components to ~2.0.1-alpha.1
* [Chore] Post-typedoc-update doc update * markdown plugin v3-like doc generation
* [create-sitecore-jss] Use version template token instead of exact version number * Updated to use env variable * Updated package.json import * Updated CHANGELOG * Don't expose canary build number * Removing upgrade guides, updated readme links * Updated CHANGELOG * Revert yarn lock * Updated package.json
|
@Elyseum thanks for the PR and sorry for the delay with feedback. |
…iring (Sitecore#1984) * send info to cloudSdk when form is submitted * update changelog * remove extra dependency * update yarn.lock * add setup file explanation, update comments * update config --------- Co-authored-by: Addy Pathania <[email protected]>
…d] Updates for Angular XMC sample to work well with local containers and spa-starters monorepo in xmcloud-foundation (Sitecore#1983) * updates to support work with local containers in xmcloud-foundation * use fs for remove/copy dist folder in proxy build * load bootstrap css fpr angular sxp only * update changelog * add clarifying comment
…um/sitecore-jss into feature/template-node-glob
@art-alexeyenko I messed up my branch in the process, so I started over in #1988. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR updates the npm lint command to use the node glob pattern (instead of the OS glob) for scaffolded projects. This makes linting results more consistent across different OS (e.g. windows development machine vs linux build server).
See https://stackoverflow.com/questions/54165756/eslint-glob-is-not-considering-all-directories-recursively
This node glob was introduced silently in the JSS development scripts (see 786913d), but it never made its way to the scaffolding templates.
Testing Details
I experienced this with an lint issue in my (customized)
packages\create-sitecore-jss\src\templates\nextjs-sxa\src\Layout.tsxfile. The lint error was detected on Windows (**/*.tsx matches direct children), but not on Ubuntu linux (**/*.tsx does NOT match direct children).After forcing to node glob pattern, the lint issue was detected on both Windows AND (Ubuntu) linux.
Types of changes